Treat enum fields as retainable objects.#2717
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Treat enum fields as retainable objects.#2717copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
This change updates the protobuf runtime to correctly handle enum fields as objects that require retain/release management, especially in non-ARC environments. The `isRetainableJavaType` function now includes `ENUM` types, and the `TYPE_RETAIN_Enum` and `TYPE_ASSIGN_Enum` macros are updated to perform retain/release operations when ARC is disabled. PiperOrigin-RevId: 900358217
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat enum fields as retainable objects.
This change updates the protobuf runtime to correctly handle enum fields as objects that require retain/release management, especially in non-ARC environments. The
isRetainableJavaTypefunction now includesENUMtypes, and theTYPE_RETAIN_EnumandTYPE_ASSIGN_Enummacros are updated to perform retain/release operations when ARC is disabled.