Refactor protobuf enum handling for proto3 unknown values.#2722
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Refactor protobuf enum handling for proto3 unknown values.#2722copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
This change introduces a new class, ComGoogleProtobufDescriptors_UnknownEnumValueDescriptor, which is a superclass of ComGoogleProtobufDescriptors_EnumValueDescriptor. When parsing a proto3 enum with an unknown value, a new instance of UnknownEnumValueDescriptor is created, allowing reflection to differentiate between known enum values and unknown ones. Enum fields now store CGPEnumValueDescriptor instances directly. Custom getter implementations are added for enum fields to return the underlying Java enum object. Type conversion macros have been refactored into inline functions for better type safety and clarity. Tests were added to verify that unknown enum values are correctly serialized back to their original wire format. PiperOrigin-RevId: 900358223
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor protobuf enum handling for proto3 unknown values.
This change introduces a new class, ComGoogleProtobufDescriptors_UnknownEnumValueDescriptor, which is a superclass of ComGoogleProtobufDescriptors_EnumValueDescriptor. When parsing a proto3 enum with an unknown value, a new instance of UnknownEnumValueDescriptor is created, allowing reflection to differentiate between known enum values and unknown ones.
Enum fields now store CGPEnumValueDescriptor instances directly. Custom getter implementations are added for enum fields to return the underlying Java enum object. Type conversion macros have been refactored into inline functions for better type safety and clarity. Tests were added to verify that unknown enum values are correctly serialized back to their original wire format.