Refactor nativeGetStackTrace to call backtrace_symbols only once when producing call stacks, rather than for every StackTraceElement.#2728
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
… producing call stacks, rather than for every StackTraceElement. This trades off better performance for stack trace production, at the cost of losing lazy-loading for fetched but unlogged stack traces. PiperOrigin-RevId: 905192033
copybara-service
Bot
force-pushed
the
test_905192033
branch
from
ddb51fe to
baf933e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor nativeGetStackTrace to call backtrace_symbols only once when producing call stacks, rather than for every StackTraceElement.
This trades off better performance for stack trace production, at the cost of losing lazy-loading for fetched but unlogged stack traces.