Fix suppressing compilation errors for dependencies in test framework - #3176
Merged
Conversation
This change throws an exception if the exit code of the Kotlin compiler is not "OK". In the test framework, when using dependencies/libraries, the Kotlin compiler must first compile those modules before KSP can run on the source module. However, if the module cannot compile KSP should not run and the test is invalid. The old code did not check the exit code and would silently suppress compilation errors. This change makes the compilation error explicit, so invalid test dependencies are caught.
jaschdoc
marked this pull request as ready for review
September 2, 2026 19:10
jaschdoc
enabled auto-merge
September 3, 2026 08:02
troelsbjerre
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change throws an exception if the exit code of the Kotlin compiler is not "OK". In the test framework, when using dependencies/libraries, the Kotlin compiler must first compile those modules before KSP can run on the source module. However, if the module cannot compile KSP should not run and the test is invalid. The old code did not check the exit code and would silently suppress compilation errors. This change makes the compilation error explicit, so invalid test dependencies are caught.