Fix CLI nontermination - #3177
Merged
Merged
Conversation
…cessor KSP's CLI entry points do not terminate if a processor throws an exception, since the background threads required by the Analysis API are never cleaned up. That code path is skipped entirely. The integration tests did not catch it since it loaded the KSP entry point within the same process. This commit adds a new set of tests that spawn a distinct processor to reproduce the failure
jaschdoc
force-pushed
the
fix-cli-nontermination
branch
from
September 3, 2026 09:50
264957a to
1509bd7
Compare
jaschdoc
marked this pull request as ready for review
September 3, 2026 10:41
jaschdoc
enabled auto-merge
September 3, 2026 10:41
troelsbjerre
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The background threads spawned by the Analysis API still continue unless the
exitProcessfunction is called. This PR adds a parameterized test that checks for nontermination (with a 1 minute timeout). It then wraps all CLI entry points in a try-catch that manually prints the stack trace in the error case and callsexitProcessto ensure the process halts.Closes #3120