feat(matcher): add custom matcher to handle regexp/glob/etc for startupcpuboost containerName#150
Open
ggiacobazzi wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for pattern matching in the
containerNamefield ofStartupCPUBoostresource policies, allowing policies to target multiple containers dynamically.Enhancements for container policy matching:
Added a custom
pattern.Matcherto support exact strings, glob wildcards (e.g.,web-*), and regular expressions (e.g.,^(app|api).*$), enabling broader targeting of containers.Updated the core
StartupCPUBoostImplto evaluate container policies based on pattern specificity (Exact > Glob > Regex > Wildcard). The first matching policy according to this precedence order is applied.Included new examples and precedence order documentation in the
README.mdand added apattern-matching-examples.yamlmanifest to demonstrate the new configuration options.This pull request solves #129
p.s great tool :)