Minor wording updates to the undefined behavior section #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Preserve the parallel between "unsafe traits and functions" at the beginning of the paragraph with "unsafe impls and blocks in the middle, by adding "impls and". - Remove "even" for the condition of unsafe code being unsound at the end of the paragraph. With my understanding of English, "even when" means that the sentence holds even when (no pun intended) the "when" condition is removed, which is not true for that sentence. Sound unsafe code can trigger undefined behavior if its safety conditions are not upheld.
djkoloski
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve the parallel between "unsafe traits and functions" at the beginning of the paragraph with "unsafe impls and blocks" in the middle, by adding "impls and".
Remove "even" for the condition of unsafe code being unsound at the end of the paragraph. With my understanding of English, "even when" means that the sentence holds even when (no pun intended) the "when" condition is removed, which is not true for that sentence. Sound unsafe code can trigger undefined behavior if its safety conditions are not upheld.