Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces an internal _time feature to measure inference time in the Rust CLI. The implementation is mostly correct, but I've found a critical issue in how the average inference time is calculated, which leads to an incorrect metric. I've also identified a potential division-by-zero error and a minor style issue. My review includes suggestions to fix these issues to ensure the feature provides accurate measurements and the code is robust and idiomatic.
|
Was doing some clean up and saw this, makes sense to merge this one, seems useful? |
It depends how often we need to do measure performance. From experience it doesn't seem that often, so I would say we simply close this. |
No description provided.