Update imports to be modules not classes#46
Merged
jeffcarp merged 1 commit intogoogle:mainfrom Mar 27, 2025
Merged
Conversation
jeffcarp
force-pushed
the
imports
branch
2 times, most recently
from
d26a8a8 to
76c899c
Compare
Collaborator
|
LGTM. let's clean up the lint check |
This aligns with the Google style guide: https://google.github.io/styleguide/pyguide.html#22-imports Also remove `__all__` from `__init__.py` files. This only applies when using `import *`, which is not common or recommended, so it's not worth us protecting against within the library.
Collaborator
Author
|
Done thanks. Added a note about linting to CONTRIBUTING.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns with the Google style guide:
https://google.github.io/styleguide/pyguide.html#22-imports
Also remove
__all__from__init__.pyfiles. This only applies when usingimport *, which is not common or recommended, so it's not worth us protecting against within the library.