Skip to content

perf(buffer_object): use madvise for kernel memory hints #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
g-husam wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf(buffer_object): use madvise for kernel memory hints #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/ml_flashpoint/checkpoint_object_manager/buffer_object/buffer_helper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,13 @@ absl::Status create_file_and_mmap(const std::string& object_id, size_t size,
return ErrnoToStatus("mmap() failed for file: " + object_id);
}

// On success, set kernel memory hints:
// MADV_WILLNEED: expect access in the near future, so can prefetch
// pages into memory in the background.
// MADV_HUGEPAGE: use huge pages when possible, to minimize TLB misses and
// improve read/write throughput.
madvise(ptr, size, MADV_WILLNEED | MADV_HUGEPAGE);

// On success, set all the output parameters.
out_fd = fd;
out_data_size = size;
Expand Down Expand Up @@ -173,6 +180,13 @@ absl::Status open_file_and_mmap_ro(const std::string& object_id, int& out_fd,
return ErrnoToStatus("mmap() failed for file: " + object_id);
}

// On success, set kernel memory hints:
// MADV_WILLNEED: expect access in the near future, so can prefetch
// pages into memory in the background.
// MADV_HUGEPAGE: use huge pages when possible, to minimize TLB misses and
// improve read throughput.
madvise(ptr, size, MADV_WILLNEED | MADV_HUGEPAGE);

// On success, set all the output parameters.
out_fd = fd;
out_data_size = size;
Expand Down Expand Up @@ -271,4 +285,4 @@ absl::Status unmap_and_close(int fd, void* data_ptr, size_t data_size,
}

} // namespace
// ml_flashpoint::checkpoint_object_manager::buffer_object::internal
// ml_flashpoint::checkpoint_object_manager::buffer_object::internal
Loading