Skip to content

fix: ensure non-zero exit code on TestAbortAll (#960) #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amytsengtw wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: ensure non-zero exit code on TestAbortAll (#960) #997

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
553448d
fix: ensure non-zero exit code on TestAbortAll (#960)
amytsengtw Dec 24, 2025
f9ba2c8
docs: fix typo in testbed_name
amytsengtw Jan 13, 2026
42d783b
fix: address review comments and add unit test for TestAbortAll exit …
amytsengtw Jan 13, 2026
f98161e
fix: address review comments and add self-contained unit test
amytsengtw Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions mobly/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,10 @@ def main(argv=None):
runner.run()
ok = runner.results.is_all_pass and ok
except signals.TestAbortAll:
pass
ok = False
Copy link
Collaborator

@xpconanfan xpconanfan Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's stay consistent with the next block in terms of the order between the two lines

logging.error('Test run aborted by TestAbortAll.')
except Exception:
logging.exception('Exception when executing %s.', config.testbed_name)
logging.exception('Exception when executing %s.', config.test_bed_name)
ok = False
if not ok:
sys.exit(1)
Expand Down
Loading