Remove remaining references to breakpad #1367
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukawa
force-pushed
the
issue_1263_breakpad
branch
from
3a0f5b7 to
e4e7f05
Compare
Collaborator
|
Thank you for your PR. Since I also already have a similar change and this removal requires some internal changes, I will apply my change first. However, I probably need several days to make it happen. At this moment, please keep this PR as-is. Thank you for your cooperation. |
With the removal of mozc::CrashReportHandler [1], breakpad is no longer used even when branding=GoogleJapaneseInput in the GYP build. It should now be safe to remove all the remaining references to breakpad from the codebase. Removing breakpad is also a step toward removing the dependency on git submodules (google#1320), as it has never been used in the bazel build. Closes google#1263. [1]: b7f08d6
yukawa
force-pushed
the
issue_1263_breakpad
branch
from
e4e7f05 to
4c48deb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the removal of
mozc::CrashReportHandler(b7f08d6),breakpadis no longer used even whenbranding=GoogleJapaneseInputin the GYP build. It should now be safe to remove all the remaining references tobreakpadfrom the codebase.Removing
breakpadis also a step toward removing the dependency on git submodules (#1320), as it has never been used in the bazel build.Closes #1263.
Issue IDs
mozc::CrashReportHandlerand the dependency onbreakpad#1263Steps to test new behaviors