Use ARM64-native LLVM binaries on Windows ARM64 #1382
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, 'update_deps.py' always downloaded x86_64 LLVM toolchains for Windows, even on ARM64 machines. While these binaries can still run under WoA emulation, it is preferable to use ARM64-native binaries when possible for better performance. Let's do so as part of the ongoing efforts to support ARM64 Windows machines (issue google#1296). With this commit, 'update_deps.py' starts downloading platform-native LLVM toolchains rather than always downloading x86_64 ones. Note that LLVM version remains unchanged to be 20.1.1. Thus there should be no bit-level differences for the generated binaries.
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously,
update_deps.pyalways downloaded x86_64 LLVM toolchains for Windows, even on ARM64 machines. While these binaries can still run under WoA emulation, it is preferable to use ARM64-native binaries when possible for better performance. Let's do so as part of the ongoing efforts to support ARM64 Windows machines.With this commit,
update_deps.pystarts downloading platform-native LLVM toolchains rather than always downloading x86_64 ones.Note that LLVM version remains unchanged to be 20.1.1. Thus there should be no bit-level differences for the generated binaries.
Issue IDs
Steps to test new behaviors (if any)
python3 build_tools/update_deps.pythird_party/llvm/bin/clang-cl.exeis an ARM64 native binary.