-
Notifications
You must be signed in to change notification settings - Fork 322
feat: Auto multichannel setup for image layers #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I tried this with the first zarr from the institute and got this error Error parsing "name" property: Expected string, but received: undefined. i'm not sure if this is because it's searching for something needs to exist in the spec and this file doesn't have it, or its optional and neuroglancer should handle it, or whether its a full on bug. what I can say is that neuroglancer handled this zarr before this PR and now does not. |
Thanks for catching this one! Misunderstood the |
some feedback... In multichannel setup, opacity of layers should be 1.0 by default, and additive blending mode by default. |
This is fantastic, @seankmartin! (and thanks @fcollman for making me aware of this effort) I tried it out on some of our data converted with Fiji. It's very intuitive to use and should address #541. There is another data set that we converted with bioformats2raw, where I ran into a couple of issues. You can load it from here:
This image has OMERO metadata, including channel colors. However, the colors are all set to black when the multichannel layer is created. The second problem is that the image itself does not render correctly, due to the |
some comments.. the metadata in the .zattrs files seems to be this
|
Thanks @krokicki and @fcollman, glad to hear and really appreciate the detailed feedback and examples, that's a big help! I think I got the first issue with the color, misread the spec and thought that the color was expected to be in As for the channel ordering, taking a look at that |
Works brilliantly. Thank you for such a quick fix! We also have some data that will have dozens of channels (many rounds of FISH labeling). I don't have any of that data yet, but I made a synthetic data set with 6 channels, and that works nicely. I think the default of only showing the first 4 is great. I can't wait until this is merged, and in the meantime I'll probably set this up on an internal instance so we can start using it. |
This is to introduce a new behaviour where the new tool palettes are leveraged to create a more automated setup for multi-channel image datasets (and optionally can be also used for single channel image datasets).
Entry points
The first entry point to this is when making a

new
layer:In this case, the user can pick whether to use the default image layer setup, or the multi-channel setup, even if they only have one channel. The option is given because the setup does some things like setting a different shader, creating a tool palette, setting default contrast limits etc.
The other entry point to this is when making an
auto
layer. In this case it only does the multi-channel setup if more than one channel is in the data.Setup behaviour
The following happens:
LAYERNAME cCHANNELDIM1_CHANNELDIM2...
unless the omero label metadata is present, in which case that is used instead.Example
Example
auto
mode setup (dimensions manually shuffled from t z y x to x y z t after setup). Could consider doing that as part of setup I guess if helpful.