Skip to content

Expand render datasource functionality #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 14, 2025

Conversation

minnerbe
Copy link
Contributor

@minnerbe minnerbe commented May 7, 2025

Hi, I'm a software engineer at HHMI/Janelia working on Render. Neuroglancer is an integral part of our EM-reconstruction pipeline and this PR updates the Render datasource to better align with the current capabilities of the Render web service. The key changes are:

  1. Improved support for optional query parameters specified in the datasource url in the format ?key=value, which are now forwarded directly to the Render web service rather than being hardcoded in neuroglancer. This allows support for parameters introduced in recent versions or forks, without any changes to the existing url syntax.
  2. Autocompletion for query parameters was added by dynamically fetching the Swagger schema of the Render service. This improves discoverability and ease of use; see screenshot below.
  3. PNG support for both 8bit and 16bit sources was added. Previously, only 8bit jpeg and 16bit raw formats were supported. As we're increasingly handling 16bit sources internally, this was one of the main motivations for creating this PR.

Looking forward to your feedback!

image

Copy link

google-cla bot commented May 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@minnerbe
Copy link
Contributor Author

minnerbe commented May 7, 2025

Just to add a bit of context: I don't have a lot of experience with JavaScript/TypeScript—my main languages are Python and Java. I relied on internal feedback and some AI-based tooling to resolve language-specific issues, so I'm definitely open to suggestions on best practices or cleaner approaches!

@fcollman
Copy link
Contributor

fcollman commented May 7, 2025

Thank you for working on this!

@minnerbe
Copy link
Contributor Author

minnerbe commented May 8, 2025

Thanks for your prompt response! I had to sort out the proper way to sign the CLA on behalf of HHMI/Janelia. Everything should be in order now, the corresponding check is passing.

@jbms jbms merged commit 3c449fd into google:master May 14, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants