Add FindSetElements method #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgarlis
force-pushed
the
add-get-setelem
branch
from
9c05161 to
793210a
Compare
stapelberg
reviewed
Nov 14, 2025
nftables_test.go
Outdated
| t.Run(tt.name, func(t *testing.T) { | ||
| conn, newNS := nftest.OpenSystemConn(t, *enableSysTests) | ||
| defer nftest.CleanupSystemConn(t, newNS) | ||
| conn.FlushRuleset() |
Collaborator
There was a problem hiding this comment.
Why the flush directly after creating the connection? If it’s required, can you add a comment to explain?
Contributor
Author
There was a problem hiding this comment.
It should have been deferred. It is actually not needed
Introduce a FindSetElements method to easily query elements in a set. Also refactor GetSetElements into a reusable getSetElements helper, shared across methods performing NFT_MSG_GETSETELEM. Fixes: google#131 Fixes: google#315
nickgarlis
force-pushed
the
add-get-setelem
branch
from
793210a to
52a7e37
Compare
stapelberg
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a FindSetElements method to easily query elements in a set. Also refactor GetSetElements into a reusable getSetElements helper, shared across methods performing NFT_MSG_GETSETELEM.
Fixes: #131
Fixes: #315