Marshal set element counter #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The counter is currently unmarshaled into the Counter field, but it is not being marshaled into binary when creating a set element. This change ensures the counter is included during marshaling.
stapelberg
approved these changes
Nov 17, 2025
Collaborator
|
GitHub Actions says that this change breaks |
Contributor
Author
Seems like a flaky test. EINTR, was received for some reason. I'll try to investigate this evening. Let's hold off merging until then. |
Contributor
Author
|
I can confirm that the flakiness is reproducible on the main branch as well. I will be opening a PR with a fix and an explanation. Re-running the tests for this PR should make them pass. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The counter is currently unmarshaled into the Counter field, but it is not being marshaled into binary when creating a set element. This change ensures the counter is included during marshaling.