Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to GKE by default from the tool #2686

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

jianglai
Copy link
Collaborator

@jianglai jianglai commented Feb 24, 2025

This change is Reviewable

@jianglai jianglai requested a review from gbrodman February 24, 2025 14:06
Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


core/src/main/java/google/registry/tools/RegistryCli.java line 158 at r1 (raw file):

    checkState(!useGke || !useGae, "Cannot specify both --gke and --gae");

    // Connect to GKE by default if neither --gae nor --gke is set.

shouldn't we just remove the --gke flag entirely and use that unless --gae is specified?

Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jianglai)

Copy link
Collaborator Author

@jianglai jianglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gbrodman)


core/src/main/java/google/registry/tools/RegistryCli.java line 158 at r1 (raw file):

Previously, gbrodman wrote…

shouldn't we just remove the --gke flag entirely and use that unless --gae is specified?

Good point. Done.

@jianglai jianglai enabled auto-merge February 24, 2025 16:23
Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jianglai)


core/src/main/java/google/registry/tools/RegistryCli.java line 158 at r1 (raw file):

Previously, jianglai (Lai Jiang) wrote…

Good point. Done.

cool yeah then when we remove GAE we can just remove this var everywhere

we could potentially change everywhere to use useGae instead of useGke but eh that's probably not worth it in this PR

@jianglai jianglai added this pull request to the merge queue Feb 24, 2025
Merged via the queue into google:master with commit 397f800 Feb 24, 2025
9 checks passed
@jianglai jianglai deleted the tool-gke branch February 24, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants