Refactor logic out of domain create flow tests #2688
+67
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CydeWeys
force-pushed
the
domain-create-tests
branch
from
eef1ed0 to
d6ca291
Compare
gbrodman
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @CydeWeys)
This removes logic from an inner helper method so that it becomes more clear from callsites within each test exactly which behavior is expected from those test conditions.
CydeWeys
force-pushed
the
domain-create-tests
branch
from
d6ca291 to
73b8880
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes logic from an inner helper method so that it becomes more clear from callsites within each test exactly which behavior is expected from those test conditions.
This change is