-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade nodes type for pubapi and console, enable bursting for frontend and backend #2723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ptkach)
a0e12d0
to
bfe5d3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @weiminyu)
jetty/kubernetes/nomulus-console.yaml
line 25 at r2 (raw file):
resources: requests: cloud.google.com/pod-slots: 0
Maybe add a comment explaining what's going on here with setting these to 0
?
jetty/kubernetes/nomulus-pubapi.yaml
line 29 at r2 (raw file):
memory: "512Mi" limits: cloud.google.com/pod-slots: 0
Extra trailing spaces here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There probably should be some explanation to what pod-slots does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @CydeWeys and @weiminyu)
jetty/kubernetes/nomulus-console.yaml
line 25 at r2 (raw file):
Previously, CydeWeys (Ben McIlwain) wrote…
Maybe add a comment explaining what's going on here with setting these to
0
?
Done.
jetty/kubernetes/nomulus-pubapi.yaml
line 29 at r2 (raw file):
Previously, CydeWeys (Ben McIlwain) wrote…
Extra trailing spaces here.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @weiminyu)
This change is