Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade nodes type for pubapi and console, enable bursting for frontend and backend #2723

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

ptkach
Copy link
Collaborator

@ptkach ptkach commented Mar 19, 2025

This change is Reviewable

@ptkach ptkach requested a review from weiminyu March 19, 2025 18:39
Copy link
Collaborator

@weiminyu weiminyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ptkach)

@ptkach ptkach changed the title Change gke node class to Balanced Change gke node class to Default Mar 19, 2025
@ptkach ptkach added the WIP Work in progress. Don't review yet. label Mar 19, 2025
@ptkach ptkach force-pushed the gkeNodeClass branch 2 times, most recently from a0e12d0 to bfe5d3f Compare March 27, 2025 15:01
@ptkach ptkach changed the title Change gke node class to Default Downgrade nodes type for pubapi and console, enable bursting for frontend and backend Mar 27, 2025
@ptkach ptkach requested a review from CydeWeys March 27, 2025 15:46
Copy link
Member

@CydeWeys CydeWeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @weiminyu)


jetty/kubernetes/nomulus-console.yaml line 25 at r2 (raw file):

        resources:
          requests:
            cloud.google.com/pod-slots: 0

Maybe add a comment explaining what's going on here with setting these to 0?


jetty/kubernetes/nomulus-pubapi.yaml line 29 at r2 (raw file):

            memory: "512Mi"
          limits:
            cloud.google.com/pod-slots: 0          

Extra trailing spaces here.

Copy link
Collaborator

@jianglai jianglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There probably should be some explanation to what pod-slots does.

Copy link
Collaborator Author

@ptkach ptkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @CydeWeys and @weiminyu)


jetty/kubernetes/nomulus-console.yaml line 25 at r2 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

Maybe add a comment explaining what's going on here with setting these to 0?

Done.


jetty/kubernetes/nomulus-pubapi.yaml line 29 at r2 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

Extra trailing spaces here.

Done.

Copy link
Member

@CydeWeys CydeWeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @weiminyu)

@ptkach ptkach added this pull request to the merge queue Mar 28, 2025
Merged via the queue into google:master with commit c15dec4 Mar 28, 2025
8 of 9 checks passed
@ptkach ptkach deleted the gkeNodeClass branch March 28, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress. Don't review yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants