Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old console history Java classes #2726

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove old console history Java classes #2726

wants to merge 1 commit into from

Conversation

gbrodman
Copy link
Collaborator

@gbrodman gbrodman commented Mar 21, 2025 •
edited by jianglai
Loading

  1. This doesn't remove the SQL tables yet (this is necessary to pass tests and also good practice just in case we need or want to look at history for a little bit)
  2. This also removes the Registrar, RegistrarPoc, and User base classes that were only necessary because we were saving copies of those objects in the old history classes.

This change is Reviewable

@gbrodman
Remove old console history Java classes
9ef7099 
1. This doesn't remove the SQL tables yet (this is necessary to pass
   tests and also good practice just in case we need or want to look at
history for a little bit)
2. This also removes the Registrar, RegistrarPoc, and User base classes
   that were only necessary because we were saving copies of those
objects in the old history classes.
@gbrodman gbrodman requested a review from ptkach March 21, 2025 17:27
@gbrodman
Copy link
Collaborator Author

friendly ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptkach ptkach Awaiting requested review from ptkach

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gbrodman