Add GetServiceState action for MoSAPI service monitoring #2906

njshah301 · 2025-12-16T15:53:03Z

Implements the /api/mosapi/getServiceState endpoint to retrieve service health summaries for TLDs from the MoSAPI system.

Introduces GetServiceStateAction to fetch TLD service status.
Implements MosApiStateService to transform raw MoSAPI responses into a curated ServiceStateSummary.
Uses concurrent processing with a fixed thread pool to fetch states for all configured TLDs efficiently while respecting MoSAPI rate limits.

junit test added

This change is

njshah301 · 2025-12-17T17:46:12Z

Gentle ping.

Implements the `/api/mosapi/getServiceState` endpoint to retrieve service health summaries for TLDs from the MoSAPI system. - Introduces `GetServiceStateAction` to fetch TLD service status. - Implements `MosApiStateService` to transform raw MoSAPI responses into a curated `ServiceStateSummary`. - Uses concurrent processing with a fixed thread pool to fetch states for all configured TLDs efficiently while respecting MoSAPI rate limits. junit test added

CydeWeys

@CydeWeys made 1 comment.
Reviewable status: 0 of 25 files reviewed, 1 unresolved discussion (waiting on @gbrodman and @njshah301).

core/src/test/java/google/registry/mosapi/model/ServiceStateSummaryTest.java line 78 at r2 (raw file):

  void testJsonDeserialization() {
    String json =
        "{"

Use the Java multi-line string format here and elsewhere. It will also make the quote mark escaping less painful.

CydeWeys

@CydeWeys made 4 comments.
Reviewable status: 0 of 25 files reviewed, 5 unresolved discussions (waiting on @gbrodman and @njshah301).

core/src/main/java/google/registry/mosapi/GetServiceStateAction.java line 35 at r2 (raw file):

    auth = Auth.AUTH_ADMIN)
public class GetServiceStateAction implements Runnable {
  private static final FluentLogger logger = FluentLogger.forEnclosingClass();

More nits, but: generally class declarations look nicer with a blank line after them, to give proper separation to the variables.

core/src/main/java/google/registry/mosapi/GetServiceStateAction.java line 64 at r2 (raw file):

        response.setPayload(gson.toJson(stateService.getServiceStateSummary(tld.get())));
      } else {
        response.setPayload(gson.toJson(stateService.getAllServiceStateSummaries()));

getAllServiceStateSummaries() is defined with the following catch block in it:

} catch (MosApiException e) {
                            logger.atWarning().withCause(e).log(
                                "Failed to get service state for TLD %s.", tld);
                            // we don't want to throw exception if fetch failed
                            return new ServiceStateSummary(tld, FETCH_ERROR_STATUS, null);
                          }

but then here a few lines below you are also catching the MosApiException and logging it again? Seems like the same problem is going to be logged multiple times in different places? Or are these different errors? It's kind of hard to tell what exceptions are being handled where because everything is just a generic MosApiException.

core/src/main/java/google/registry/config/RegistryConfigSettings.java line 275 at r2 (raw file):

    public List<String> tlds;
    public List<String> services;
    public Integer tldThreadCnt;

Why Integer instead of int as elsewhere in this file?

core/src/main/java/google/registry/config/files/default-config.yaml line 645 at r2 (raw file):

  - "dnssec"

  #Provides a fixed thread pool for parallel TLD processing.

Missing space after pound sign.

CydeWeys

@CydeWeys made 1 comment.
Reviewable status: 0 of 25 files reviewed, 6 unresolved discussions (waiting on @gbrodman and @njshah301).

core/src/main/java/google/registry/mosapi/model/IncidentSummary.java line 27 at r2 (raw file):

 *     5.1</a>
 */
public final class IncidentSummary {

Should this perhaps be a record type, or will that not work with Gson annotations? Same comment on below classes as well.

CydeWeys

@CydeWeys made 1 comment.
Reviewable status: 0 of 25 files reviewed, 7 unresolved discussions (waiting on @gbrodman and @njshah301).

core/src/main/java/google/registry/mosapi/MosApiStateService.java line 55 at r2 (raw file):

  /** Shared internal logic to fetch raw data from ICANN MoSAPI state monitoring. */
  private TldServiceState fetchRawState(String tld) throws MosApiException {

Are these one line pass-through private functions really necessary? It doesn't seem like they're doing much at all.

njshah301

@njshah301 made 7 comments and resolved 1 discussion.
Reviewable status: 0 of 25 files reviewed, 6 unresolved discussions (waiting on @CydeWeys and @gbrodman).

core/src/main/java/google/registry/config/RegistryConfigSettings.java line 275 at r2 (raw file):