OboeTester: Use shared stream for cold start latency test#2358
Merged
Conversation
flamme
reviewed
Apr 3, 2026
Collaborator
flamme
left a comment
flamme
left a comment
There was a problem hiding this comment.
I'm a bit confused. mStream itself is shared pointer, it should guarantee alive unless open failed and it doesn't get allocated.
Collaborator
Author
|
This fix isn't for the crash but for making sure that cold start latency gets shown after requestStart() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a shared stream as the original shared stream could be closed when the app is closed.
Fixes internal bug b/496584594