Skip to content

Samples: Add OboeDJ#2359

Merged
robertwu1 merged 1 commit into
mainfrom
robertwu/oboedj
Apr 8, 2026
Merged

Samples: Add OboeDJ#2359
robertwu1 merged 1 commit into
mainfrom
robertwu/oboedj

Conversation

@robertwu1
Copy link
Copy Markdown
Collaborator

Adding a sample for OboeDJ

@robertwu1 robertwu1 requested a review from madebymozart April 1, 2026 19:32
Copy link
Copy Markdown
Collaborator

@madebymozart madebymozart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small. non-blocking nits

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 3 places will use this now, maybe we have a small shared resource for these songs to be referenced from

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's do this in a follow-up CL since we are both modifying files

Comment thread samples/OboeDJ/src/main/cpp/SoundPlayer.h
@robertwu1 robertwu1 merged commit c389048 into main Apr 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants