Skip to content

OboeTester: Fix external tap to tone crash#2362

Merged
robertwu1 merged 1 commit into
mainfrom
robertwu/externaltaptotonecrash
Apr 6, 2026
Merged

OboeTester: Fix external tap to tone crash#2362
robertwu1 merged 1 commit into
mainfrom
robertwu/externaltaptotonecrash

Conversation

@robertwu1
Copy link
Copy Markdown
Collaborator

Fixes internal bug b/499376455

This is caused by #2361 changing TapToToneTester when it's also used in ExternalTapToToneActivity.java.

@robertwu1 robertwu1 requested a review from hasinur010 April 3, 2026 23:41
Copy link
Copy Markdown
Collaborator

@hasinur010 hasinur010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing the crash.

@robertwu1 robertwu1 merged commit 396a369 into main Apr 6, 2026
3 checks passed
@robertwu1 robertwu1 deleted the robertwu/externaltaptotonecrash branch April 6, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants