Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more type annotation fixes #4122

Merged
merged 1 commit into from
Mar 10, 2024
Merged

more type annotation fixes #4122

merged 1 commit into from
Mar 10, 2024

Conversation

dimbleby
Copy link

@dimbleby dimbleby commented Mar 9, 2024

simplifying and - I think! - correcting more python type annotations. Not so straightforward as #4121, you'll probably want to think about it...

  • an IntVar is a LinearExpr, so a union containing them both is pointless, it might as well just contain a LinearExpr
  • likewise an Integral is already a Number

then try to correct the annotations for __add__ etc, by making them all just return a new LinearExpr - which I am fairly sure is true.

Copy link

google-cla bot commented Mar 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lperron lperron merged commit 2319f87 into google:main Mar 10, 2024
76 of 114 checks passed
@Mizux Mizux requested a review from lperron March 10, 2024 17:13
@Mizux Mizux added Bug Lang: Python Python wrapper issue labels Mar 10, 2024
@Mizux Mizux added this to the v10.0 milestone Mar 10, 2024
@Mizux Mizux modified the milestones: v10.0, v9.10 Apr 26, 2024
@Mizux Mizux self-assigned this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Lang: Python Python wrapper issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants