Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] expat: Fix build #13015

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

hartwork
Copy link
Contributor

@hartwork hartwork commented Feb 7, 2025

Gets me compile errors…

/src/expat/build/libprotobuf-mutator/src/libprotobuf-mutator/src/mutator.cc:90:41: error: no member named 'has_presence' in 'google::protobuf::FieldDescriptor'
   90 |   return !field.is_repeated() && !field.has_presence();
      |                                   ~~~~~ ^
[ 48%] Linking C executable tests/runtests
/src/expat/build/libprotobuf-mutator/src/libprotobuf-mutator/src/mutator.cc:383:15: error: call to non-static member function without an object argument
  383 |   return Any::GetDescriptor() == message->GetDescriptor()
      |          ~~~~~^~~~~~~~~~~~~
/src/expat/build/libprotobuf-mutator/src/libprotobuf-mutator/src/mutator.cc:389:15: error: call to non-static member function without an object argument
  389 |   return Any::GetDescriptor() == message->GetDescriptor()
      |          ~~~~~^~~~~~~~~~~~~
/src/expat/build/libprotobuf-mutator/src/libprotobuf-mutator/src/text_format.cc:31:10: error: no member named 'SetRecursionLimit' in 'google::protobuf::TextFormat::Parser'
   31 |   parser.SetRecursionLimit(100);
      |   ~~~~~~ ^
/src/expat/build/libprotobuf-mutator/src/libprotobuf-mutator/src/text_format.cc:33:10: error: no member named 'AllowUnknownField' in 'google::protobuf::TextFormat::Parser'
   33 |   parser.AllowUnknownField(true);
      |   ~~~~~~ ^

…due to too-old libprotobuf-dev 3.6.1.3-2ubuntu5.2 in Ubuntu 20.04.

Seems doomed to fail with with no good options forward, see #13016 for the big picture.

Copy link

github-actions bot commented Feb 7, 2025

hartwork is either the primary contact or is in the CCs list of projects/expat.
hartwork has previously contributed to projects/expat. The previous PR was #4148

Related upstream pull requests:
- libexpat/libexpat#950
  (adds libabsl-dev, libprotobuf-dev, protobuf-compiler)
- libexpat/libexpat#952
  (drops libabsl-dev)

Signed-off-by: Sebastian Pipping <[email protected]>
Signed-off-by: Sebastian Pipping <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant