Skip to content

karchive, kimageformats, kcodecs: remove libzip dependency, fix build, add lz compression support and update homepage urls #13308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

karchive, kimageformats, kcodecs: remove libzip dependency, fix build, add lz compression support and update homepage urls #13308

wants to merge 5 commits into from

Conversation

AmazingAkai
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

AmazingAkai has previously contributed to projects/karchive. The previous PR was #13200

@AmazingAkai
Copy link
Contributor Author

Updated homepage urls since cgit was deprecated 5 years ago:
https://mail.kde.org/pipermail/kde-core-devel/2020-June/090813.html

@AmazingAkai
Copy link
Contributor Author

@tsdgeos done, can you review?

AmazingAkai
AmazingAkai commented May 13, 2025
View reviewed changes
projects/kimageformats/build.sh Outdated
./configure --static
make install -j$(nproc)

# Build libzip
cd $SRC
cd libzip
cd $SRC/libzip
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs libzip either, KImageFormats does not depend on libzip. Can I remove this too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After waiting an hour trying to compile this without libzip, I can confirm that it compiles successfully and the fuzzer runs as well, so I don’t think libzip is needed here either.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, this is just copied from karchive i guess

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@AmazingAkai AmazingAkai changed the title karchive: remove libzip because karchive does not depend on it karchive, kimageformats, kcodecs: remove libzip dependency, fix build and update homepage urls May 13, 2025
@AmazingAkai AmazingAkai force-pushed the work/amazingakai/karchive-remove-libzip branch from 2c726ef to 7bb325c Compare May 14, 2025 07:11
@AmazingAkai
Copy link
Contributor Author

Also added support for fuzzing lz compression

@AmazingAkai AmazingAkai changed the title karchive, kimageformats, kcodecs: remove libzip dependency, fix build and update homepage urls karchive, kimageformats, kcodecs: remove libzip dependency, fix build, add lz compression support and update homepage urls May 14, 2025
@tsdgeos
Copy link
Contributor

tsdgeos commented May 14, 2025

Please merge 👍 @DavidKorczynski

@AmazingAkai AmazingAkai force-pushed the work/amazingakai/karchive-remove-libzip branch from 7bb325c to 18e9fb2 Compare May 14, 2025 13:04
@AmazingAkai AmazingAkai force-pushed the work/amazingakai/karchive-remove-libzip branch from 18e9fb2 to d545dde Compare May 16, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsdgeos tsdgeos tsdgeos left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmazingAkai @tsdgeos