boringssl: fix broken build #14675
Open
boringssl: fix broken build #14675
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xingyaner is a new contributor to projects/boringssl. The PR must be approved by known contributors before it can be merged. The past contributors are: hunsche, bob-beck, vitalybuka, DonggeLiu, davidben, Navidem, inferno-chromium, sleevi, dannyallover, cvediver, Dor1s, ssbr (unverified), mikea (unverified) |
xingyaner
force-pushed
the
fix-boringssl
branch
from
3891a50 to
1723ea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fundamental reason for the failed build is the ABI conflict of the C++ standard library. That is, the Boringssl static library tends to use libstdc++, while the OSS-Fuzz environment and the precompiled Protobuf dependency force the use of libc++, resulting in symbol mismatch during linking.
The fix can be successfully carried out by modifying build.sh to force Boringssl and regular fuzzers to use libstdc++ to maintain internal consistency, while allowing LPM fuzzers that rely on Protobuf to use libc++ alone to be compatible with precompiled libraries.