[libarchive] Expand fuzzing from 1 to 25 targets #14678
Open
+125
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update build configuration to use all 25 fuzz targets now available in upstream libarchive (merged in libarchive/libarchive#2820). Changes: - Update build.sh to compile all 25 fuzzers from contrib/oss-fuzz/ - Copy dictionaries and options files for guided fuzzing - Generate seed corpora from libarchive's test files - Remove local libarchive_fuzzer.cc (now in upstream repo) New fuzzers include: - 13 format-specific: tar, zip, 7zip, rar, rar5, xar, cab, lha, iso9660, cpio, warc, mtree, ar - 4 security-critical: encryption, write_disk, read_disk, entry (ACL) - 7 API coverage: write, linkify, match, string, seek, roundtrip, filter Expected coverage improvement: 74% → 85-95%
- TAR: Change pattern from "test_compat_*tar*.uu" to "*tar*.uu" Increases coverage from 30 to 70 test files, including: - test_read_format_tar_*.uu - test_read_format_gtar_*.uu - test_pax_*.tar.uu - test_acl_pax_*.tar.uu - CPIO: Change pattern from "test_compat_cpio*.uu" to "*cpio*.uu" Increases coverage from 1 to 11 test files, including: - test_read_format_cpio_*.uu
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
skypher is a new contributor to projects/libarchive. The PR must be approved by known contributors before it can be merged. The past contributors are: Mrmaxmeier, DonggeLiu, jvoisin, cvediver, Dor1s, mmatuska (unverified) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update libarchive build configuration to use all 25 fuzz targets now available in upstream libarchive (merged in libarchive/libarchive#2820).
Changes
build.shto compile all 25 fuzzers fromcontrib/oss-fuzz/libarchive_fuzzer.cc(now in upstream repo)New Fuzzers (24 new, 25 total)
Format-specific (13):
Security-critical (4):
API coverage (7):
Coverage Targets
Previously uncovered functions now targeted:
archive_entry_linkifyxar_read_headerExpected coverage improvement: 74% → 85-95%
Testing
check_buildvalidationpython infra/helper.py build_fuzzers libarchivepython infra/helper.py check_build libarchive