eslint: initial integration#15458
Open
rootvector2 wants to merge 1 commit into
Open
Conversation
Adds three Jazzer.js fuzz targets for the public ESLint API: - fuzz_linter: drives Linter.verify with varied ECMA versions, source types, and a randomised subset of rules - fuzz_verify_and_fix: drives Linter.verifyAndFix to exercise the autofix loop and overlapping-fix path - fuzz_source_code: exercises post-parse SourceCode helpers (tokens, comments, location/scope lookups) @jazzer.js/core is pinned to 2.1.0 because the prebuilt native fuzzer in 4.x requires GLIBC 2.32, which the Ubuntu 20.04 base-runner does not provide.
|
rootvector2 is integrating a new project: |
3 tasks
DavidKorczynski
requested changes
May 8, 2026
Collaborator
DavidKorczynski
left a comment
DavidKorczynski
left a comment
There was a problem hiding this comment.
Project is good.
However, can we land the harnesses upstream? I think this is important with javascript from a perspective it's still relatively new and it would be good to have maintainers validation from building/running these and get a signal of value.
We also await maintainer coordination and acceptance.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an OSS-Fuzz integration for ESLint (https://eslint.org/), the AST-based pattern checker for JavaScript.
Three fuzz targets cover the public API surface that the project itself documents:
fuzz_linter—Linter.verifywith varied ECMA versions, source types, parser feature flags, and a randomised subset of rules so the fuzzer drives which rules get co-enabled rather than running them all every iteration.fuzz_verify_and_fix—Linter.verifyAndFixrestricted to fixable rules, to exercise the autofix loop and overlapping-fix path.fuzz_source_code— post-parseSourceCodehelpers (tokens, comments,getLocFromIndex,getScope,getAncestors).@jazzer.js/coreis pinned to2.1.0— the prebuilt native fuzzer in4.xrequires GLIBC 2.32, which the Ubuntu 20.04 base-runner doesn't provide. There's a comment inbuild.shnext to the pin.Upstream tracking issue (asking ESLint maintainers to confirm the primary contact and to LGTM here): filed alongside this PR.
Test plan
Tested locally against the cloned upstream
masterofeslint/eslint:python3 infra/helper.py build_image eslintpython3 infra/helper.py build_fuzzers eslintpython3 infra/helper.py check_build eslint— passes for all three targetspython3 infra/helper.py run_fuzzer eslint fuzz_linter— coverage growth, no crashespython3 infra/helper.py run_fuzzer eslint fuzz_verify_and_fix— coverage growth, no crashespython3 infra/helper.py run_fuzzer eslint fuzz_source_code— coverage growth, no crashespython3 infra/presubmit.py formatandlicensepass