Add two version of the Swift flags.#15459
Open
thomasvl wants to merge 1 commit into
Open
Conversation
|
thomasvl is either the primary contact or is in the CCs list of projects/swift-protobuf. |
thomasvl
force-pushed
the
swift_flags_update
branch
from
d13e7a5 to
eac7428
Compare
Member
Author
|
Looks like some infra is having a hiccup, I don't see how this is related to the changes. |
thomasvl
force-pushed
the
swift_flags_update
branch
4 times, most recently
from
5a98834 to
e732239
Compare
Depending on how a Swift package is configured (`Package.swift`), different flags may be needed. Provide variables with the two forms. Update the documentation to try and explain things and call out the likely error. Move swift-protobuf off a hardcoded override to the new values.
thomasvl
force-pushed
the
swift_flags_update
branch
from
e732239 to
74f0242
Compare
Member
Author
|
@DavidKorczynski - it looks like the failures are because the new variables I've added in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on how a Swift package is configured (
Package.swift), different flags may be needed. Provide variables with the two forms. Update the documentation to try and explain things and call out the likely error.Move swift-protobuf off a hardcoded override to the new values.