base-builder-rust: bump RUSTUP_TOOLCHAIN to nightly-2025-09-05 on ubuntu-24-04#15461
Open
masumi-ryugo wants to merge 1 commit into
Open
base-builder-rust: bump RUSTUP_TOOLCHAIN to nightly-2025-09-05 on ubuntu-24-04#15461masumi-ryugo wants to merge 1 commit into
masumi-ryugo wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot I signed it! |
…ntu-24-04 The default base-builder-rust Dockerfile was bumped to nightly-2025-09-05 in 625f70d, but the ubuntu-24-04 variant was left at the older nightly-2024-07-12, causing build failures and coverage mismatches when projects opt into ubuntu-24-04 (google#14220). The LLVM revision (cb2f0d0a5f14) is now identical across the default, ubuntu-20-04 and ubuntu-24-04 base-clang scripts, so the toolchain/LLVM compatibility concern that originally delayed this bump no longer applies. Fixes: google#14220
d8cc125 to
a388a6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14220.
The default
base-builder-rustDockerfile was bumped tonightly-2025-09-05in 625f70d, but theubuntu-24-04variant was left atnightly-2024-07-12. As reported in #14220, this causes build failures / coverage mismatches when projects opt into theubuntu-24-04image (currently 360 projects).This PR aligns
ubuntu-24-04.Dockerfilewith the default Dockerfile (1-line change).Why it's safe to bump now
The original concern raised on #13964 was that
RUSTUP_TOOLCHAINcouldn't be bumped on the new images while LLVM was at a different revision. As of master,OUR_LLVM_REVISION=cb2f0d0a5f14is identical across all threebase-clangscripts:So the toolchain/LLVM compatibility concern that delayed this no longer applies —
nightly-2025-09-05already runs successfully against this LLVM revision in the default image.Scope
ubuntu-24-04.Dockerfileis touched (the file the issue is about).ubuntu-20-04.Dockerfileis also atnightly-2024-07-12but Ubuntu 20.04 reached EOL in April 2025; whether to bump or remove that file is a separate decision and is intentionally out of scope here.