Added registryAuths copy to WithoutRegistries() + test cases #816
+102
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cuixq I fixed the lint issues and ran golangci-lint manually. There's a conflict with the rules for the trailing whitespace. If I remove that trailing whitespace, then golangci-lint complains about it not being formatted with gofmt. If I format with gofmt, then golangci-lint complains that there's trailing whitespace. |
|
hmmm weird - usually the linter is happy with what is formatted by |
|
@cuixq Figured it out. It was the line above the last one that was trailing. 🤦 |
cuixq
reviewed
Jun 10, 2025
|
@cuixq Fixed the unsafe usage as suggested. Could you please review? |
cuixq
approved these changes
Jun 12, 2025
|
@cuixq Thanks so much for the help!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #815
There is a bug where when the Maven Client is being reset to remove custom registries that were added from processing the pom.xml. The authentication configuration that was added when the client was first created with
NewMavenRegistryAPIClientwas forgotten to be copied in theWithoutRegistriesfunction.Also added test case for regression testing and also validate functionality before and after changes.