fix(customgitignore) parsing to respect repository boundaries #1859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y boundaries | fixes google#209 - Added detection of repository boundaries when parsing gitignore files - Ensures gitignore files outside of repositories are not parsed - Prevents parent repository gitignores from being applied to subrepositories - Added tests to verify the fixes work correctly
…oundaries - Updated the ParseGitIgnores comment to reflect recent logic changes - Explicitly notes that .gitignore files from parent repositories are ignored - Keeps existing structure intact to minimize comment churn
This change enhances gitignore parsing to properly handle symlinks: - Added symlink resolution to parentPath function - Enhanced isSubRepository to correctly detect repository boundaries with symlinks - Added tests for symlink handling - Updated documentation to reflect symlink handling capabilities
another-rex
approved these changes
May 9, 2025
Thank you for pointing this out; think that my tests need a more comprehensive case covering nested repo's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209
Previously,
.gitignorefiles from outside a Git repo - or from a parent repo - could be incorrectly applied.This led to unexpected exclusions in nested repository setups, such as submodules or vendored repos.
The updated logic includes proper detection of repository boundaries and support for symlink resolution to handle more complex project layouts.
Symlink resolution is fallback-safe and automatically skipped on unsupported platforms like Windows.
Changes included:
readIgnoreFilesFromParentsto stop traversal at repo boundariesisSubRepositoryto detect nested repositoriesfilepath.EvalSymlinksfor more accurate path handlingparentPathto resolve symlinked parent directoriesTests added:
.gitignoreleakage).gitignorefiles applied)The docstring for
ParseGitIgnoreswas also updated to reflect this behavior, without large structural changes.If you’d prefer the symlink logic to go in a follow-up PR, happy to split it. Thanks in advance for reviewing!
~ Pepijn