Skip to content

fix: Add ubuntu namespace to dep type of purl #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2025
Merged

Conversation

Avgor46
Copy link
Contributor

@Avgor46 Avgor46 commented Jun 1, 2025

Hi! I've added "ubuntu" namespace to deb type. Osv-scanner could not parse my custom dpkg BOM generated with osv-scalibr on Ubuntu system.

Copy link

google-cla bot commented Jun 1, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Avgor46
Copy link
Contributor Author

Avgor46 commented Jun 9, 2025

@another-rex, @cuixq, could someone review PR?

@oliverchang oliverchang requested review from another-rex and cuixq June 9, 2025 07:51
Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cuixq
Copy link
Contributor

cuixq commented Jun 10, 2025

LGTM - @Avgor46 can you address the lint issue?

@Avgor46
Copy link
Contributor Author

Avgor46 commented Jun 10, 2025

@cuixq, Fixed. It seems that this robot PR fixes all other unit tests.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.60%. Comparing base (253503e) to head (98f0cf7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1916   +/-   ##
=======================================
  Coverage   65.60%   65.60%           
=======================================
  Files         167      167           
  Lines       16060    16060           
=======================================
  Hits        10536    10536           
  Misses       4859     4859           
  Partials      665      665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cuixq cuixq merged commit 743d8ed into google:main Jun 12, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants