Skip to content

refactor: omit embedded field from accessor chain #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Jun 3, 2025

This slightly reduces coupling since the caller does not have to know about the embedded field in the middle, in addition to just overall being less code

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 72.41379% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.69%. Comparing base (7887941) to head (4ae53cc).

Files with missing lines Patch % Lines
internal/imodels/imodels.go 85.71% 0 Missing and 2 partials ⚠️
internal/resolution/manifest/maven.go 50.00% 1 Missing and 1 partial ⚠️
cmd/osv-scanner/fix/noninteractive.go 0.00% 0 Missing and 1 partial ⚠️
internal/tui/in-place-info.go 0.00% 1 Missing ⚠️
internal/tui/vuln-list.go 0.00% 1 Missing ⚠️
pkg/osvscanner/osvscanner.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1925   +/-   ##
=======================================
  Coverage   65.69%   65.69%           
=======================================
  Files         166      166           
  Lines       16058    16058           
=======================================
  Hits        10550    10550           
  Misses       4842     4842           
  Partials      666      666           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants