Skip to content

refactor: use ScanResults.Inventory.Packages directly#2617

Merged
another-rex merged 1 commit intogoogle:mainfrom
ackama:refactor/imodels-p4
Apr 24, 2026
Merged

refactor: use ScanResults.Inventory.Packages directly#2617
another-rex merged 1 commit intogoogle:mainfrom
ackama:refactor/imodels-p4

Conversation

@G-Rath
Copy link
Copy Markdown
Collaborator

@G-Rath G-Rath commented Mar 7, 2026

... and finally we come to the end (sort of): now that PackageScanResults holds *extractor.Package, we can just switch to using Inventory.Packages directly 🎉

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 7, 2026

Codecov Report

❌ Patch coverage is 91.11111% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.94%. Comparing base (3553569) to head (e5fe803).
⚠️ Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
pkg/osvscanner/filter.go 87.50% 1 Missing and 1 partial ⚠️
pkg/osvscanner/osvscanner.go 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2617      +/-   ##
==========================================
- Coverage   67.99%   67.94%   -0.05%     
==========================================
  Files         173      173              
  Lines       13387    13389       +2     
==========================================
- Hits         9102     9097       -5     
- Misses       3576     3583       +7     
  Partials      709      709              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@G-Rath G-Rath force-pushed the refactor/imodels-p4 branch 2 times, most recently from ffc2800 to 2def4c8 Compare March 11, 2026 19:08
@G-Rath G-Rath force-pushed the refactor/imodels-p4 branch from 2def4c8 to 428802d Compare March 18, 2026 17:59
@G-Rath G-Rath requested review from Ly-Joey, another-rex and cuixq March 18, 2026 18:00
@G-Rath G-Rath marked this pull request as ready for review March 18, 2026 18:00
@G-Rath G-Rath force-pushed the refactor/imodels-p4 branch from 428802d to 4903060 Compare March 18, 2026 19:34
@G-Rath G-Rath force-pushed the refactor/imodels-p4 branch from 4903060 to e5fe803 Compare March 19, 2026 20:20
@another-rex another-rex merged commit 123ef80 into google:main Apr 24, 2026
26 of 27 checks passed
@another-rex another-rex deleted the refactor/imodels-p4 branch April 24, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants