Skip to content

traceconv: implement function to go from text -> binary #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LalitMaganti
Copy link
Collaborator

Implement it in a very trivial way but better than not having it at
all

@LalitMaganti LalitMaganti requested a review from a team as a code owner May 7, 2025 19:53
@LalitMaganti LalitMaganti requested a review from rsavitski May 7, 2025 19:53
@LalitMaganti LalitMaganti force-pushed the dev/fix branch 2 times, most recently from 2222d6b to 13f6417 Compare May 7, 2025 20:31
@rsavitski rsavitski self-assigned this May 7, 2025
Implement it in a very trivial way but better than not having it at
all
Comment on lines +85 to +86
std::string trace_text((std::istreambuf_iterator<char>(*input)),
(std::istreambuf_iterator<char>()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
std::string trace_text((std::istreambuf_iterator<char>(*input)),
(std::istreambuf_iterator<char>()));
std::string trace_text(std::istreambuf_iterator<char>{*input},
std::istreambuf_iterator<char>{});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants