traceconv: implement function to go from text -> binary #1437
+47
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LalitMaganti
force-pushed
the
dev/fix
branch
2 times, most recently
from
2222d6b to
13f6417
Compare
Implement it in a very trivial way but better than not having it at all
rsavitski
reviewed
May 7, 2025
Comment on lines
+85
to
+86
| std::string trace_text((std::istreambuf_iterator<char>(*input)), | ||
| (std::istreambuf_iterator<char>())); |
There was a problem hiding this comment.
Suggested change
| std::string trace_text((std::istreambuf_iterator<char>(*input)), | |
| (std::istreambuf_iterator<char>())); | |
| std::string trace_text(std::istreambuf_iterator<char>{*input}, | |
| std::istreambuf_iterator<char>{}); |
rsavitski
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement it in a very trivial way but better than not having it at
all