Skip to content

[DNS] prototype metric templates #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

LalitMaganti
Copy link
Collaborator

No description provided.

@LalitMaganti LalitMaganti requested a review from a team as a code owner May 16, 2025 01:42
@@ -263,8 +296,12 @@ message TraceMetricV2 {
}
repeated MetricRow row = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will MetricRow.value be repeated field ?

// and a common set of dimensions. The template will then generate a set of
// metrics which share the same prefix and dimensions but differ in the value
// column.
message TraceMetricV2TemplateSpec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the TraceMetricV2Spec be expanded instead of creating a new proto ?
Creating a new repeated field value_columns where either value or value_columns are set. Similar to dimensions vs dimensions_specs change.

As it is not clear what TraceSummary output expanded version of TraceMetricV2Spec .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants