[DNS] prototype metric templates #1545
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrakadm
reviewed
May 16, 2025
| @@ -263,8 +296,12 @@ message TraceMetricV2 { | |||
| } | |||
| repeated MetricRow row = 1; | |||
There was a problem hiding this comment.
Will MetricRow.value be repeated field ?
elrakadm
reviewed
May 16, 2025
| // and a common set of dimensions. The template will then generate a set of | ||
| // metrics which share the same prefix and dimensions but differ in the value | ||
| // column. | ||
| message TraceMetricV2TemplateSpec { |
There was a problem hiding this comment.
Could the TraceMetricV2Spec be expanded instead of creating a new proto ?
Creating a new repeated field value_columns where either value or value_columns are set. Similar to dimensions vs dimensions_specs change.
As it is not clear what TraceSummary output expanded version of TraceMetricV2Spec .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.