protos: tp: ui: add "correlation id" for coloring track events #1628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LalitMaganti
changed the title
LalitMaganti
requested review from
ddiproietto,
stevegolton and
primiano
and removed request for
rsavitski and
aMayzner
LalitMaganti
force-pushed
the
dev/lalitm/tag
branch
from
b823422 to
10e0828
Compare
LalitMaganti
force-pushed
the
dev/lalitm/tag
branch
from
10e0828 to
305d211
Compare
stevegolton
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a way for users to define that "I want all of these things to have
the same color" without explicitly saying that in the trace. Instead
they define an implicit "correlation id" and we use that to make
decisions on which slices should be drawn the same color.