Skip to content

protos: tp: ui: add "correlation id" for coloring track events #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025

Conversation

LalitMaganti
Copy link
Collaborator

@LalitMaganti LalitMaganti commented May 22, 2025

Have a way for users to define that "I want all of these things to have
the same color" without explicitly saying that in the trace. Instead
they define an implicit "correlation id" and we use that to make
decisions on which slices should be drawn the same color.

@LalitMaganti LalitMaganti requested review from a team as code owners May 22, 2025 17:16
@LalitMaganti LalitMaganti changed the title dev/lalitm/tag protos: tp: ui: add "correlation id" for coloring track events May 22, 2025
@LalitMaganti LalitMaganti requested review from ddiproietto, stevegolton and primiano and removed request for rsavitski and aMayzner May 22, 2025 17:17
Copy link
Member

@stevegolton stevegolton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@LalitMaganti LalitMaganti merged commit 818ce16 into main May 28, 2025
16 of 19 checks passed
@LalitMaganti LalitMaganti deleted the dev/lalitm/tag branch May 28, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants