protos: tp: ui: add explicit enum for track_event merging #1630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LalitMaganti
requested review from
aMayzner,
rsavitski,
ddiproietto,
primiano and
etiennep-chromium
and removed request for
rsavitski and
aMayzner
LalitMaganti
changed the title
LalitMaganti
force-pushed
the
dev/lalitm/merge
branch
from
d0384d4 to
8c6c85f
Compare
ddiproietto
approved these changes
May 23, 2025
| // Resulting UI (when merging by SIBLING_MERGE_KEY): | ||
| // SystemActivity | ||
| // ├── AuthService (merged by smk: "auth_main_cluster") | ||
| // │ ├── LoginOp (merged by smk: "login_v1") |
There was a problem hiding this comment.
// │ ├── LoginOp (merged by smk: "login_v1")
// │ └── LoginOp (merged by smk: "login_v1")
primiano
approved these changes
May 27, 2025
LalitMaganti
force-pushed
the
dev/lalitm/merge
branch
from
8c6c85f to
dcd4619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds an explicit proto for deciding how track_event tracks should be merged together in the UI (and eventually the trace processor). Until now we've relied on a very implicit merging scheme but with this change, we can now properly define this and allow users to choose how they want merging to happen.