DatasetSliceTrack - Dynamic Datasets #1638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I0a68d0af34f402c62b2153d80e5c6d0262a8634d
stevegolton
changed the title
LalitMaganti
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the interface to
DatasetSliceTrack, allowing it to take either a static dataset or a dynamic dataset (a function that returns a dataset, called on the track's onUpdate() hook).This allows the dataset to be tweaked by the plugin that registers the track depending on some other internal state of the plugin.
If the dataset's resultant query changes from frame to frame, the track's internal state and any tables are dropped, and the track data is reloaded.