Skip to content

DatasetSliceTrack - Dynamic Datasets #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

stevegolton
Copy link
Member

This change modifies the interface to DatasetSliceTrack, allowing it to take either a static dataset or a dynamic dataset (a function that returns a dataset, called on the track's onUpdate() hook).

This allows the dataset to be tweaked by the plugin that registers the track depending on some other internal state of the plugin.

If the dataset's resultant query changes from frame to frame, the track's internal state and any tables are dropped, and the track data is reloaded.

Change-Id: I0a68d0af34f402c62b2153d80e5c6d0262a8634d
@stevegolton stevegolton requested a review from LalitMaganti May 23, 2025 17:52
@stevegolton stevegolton requested a review from a team as a code owner May 23, 2025 17:52
@stevegolton stevegolton changed the title Allow DatasetSliceTrack to take a function that returns a dataset as well as a dataset DatasetSliceTrack - Dynamic Datasets May 23, 2025
@stevegolton stevegolton merged commit aeddce7 into main May 27, 2025
12 of 15 checks passed
@stevegolton stevegolton deleted the dev/stevegolton/dynamic-datasets branch May 27, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants