tp: significantly speed up compile of trace processor #4194
+1,425
−1,411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a much more efficient template algorithm similar to what libc++ itself uses interally for a lot of its metaprogramming functions
LalitMaganti
force-pushed
the
dev/lalitm/compile-2
branch
from
c113db0 to
ade37d7
Compare
LalitMaganti
force-pushed
the
dev/lalitm/compile-2
branch
from
ade37d7 to
a81d469
Compare
LalitMaganti
changed the title
dreveman
approved these changes
Dec 30, 2025
Collaborator
dreveman
left a comment
dreveman
left a comment
There was a problem hiding this comment.
Scanned through the changes. Looks reasonable to me but too large of a change for me to provide a detailed review. I assume that runtime performance has been verified to not regress from this, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many many improvements: