Open
Conversation
Now that libc++ is available as a shlib, switch to that in our test targets. libc++_static seemst to create ODR violations if somebody else (e.g. libandroid.so) pull a shared version of it. Bug: b/482864728 Bug: b/481873842 Bug: b/483005117
🎨 Perfetto UI Builds |
primiano
changed the title
Member
|
Should we land this? |
LalitMaganti
approved these changes
Feb 11, 2026
Member
Author
|
Keep this on hold. The author of the original breakage says that ag/38385143 is supposed to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that libc++ is available as a shlib, switch to
that in our test targets.
libc++_static seemst to create ODR violations if
somebody else (e.g. libandroid.so) pull a shared version of it.
Bug: b/482864728
Bug: b/481873842
Bug: b/483005117