Conversation
🎨 Perfetto UI Builds |
| // the new instance and ownership is transferred to the caller. | ||
| virtual base::Status CreateSummarizer(std::unique_ptr<Summarizer>* out) = 0; | ||
|
|
||
| // EXPERIMENTAL: Converts a proto from binary format to textproto format. |
There was a problem hiding this comment.
Uhhhhh why do you need this? This seems totally unnecessary.
| // the new instance and ownership is transferred to the caller. | ||
| virtual base::Status CreateSummarizer(std::unique_ptr<Summarizer>* out) = 0; | ||
|
|
||
| // EXPERIMENTAL: Converts a proto from binary format to textproto format. |
There was a problem hiding this comment.
No sorry please don't add a function like this, this is totally not the right thing to do. You should be able to convert to text proto in JavaScript without going to trace processor. If you need to do it on c++ see how it's done for trace config and generalize. I've allowed ad-hoc changes on TP and not looked too closely but this is where I draw the line. I don't want to add random things in TP just because it's convenient for explore page.
There was a problem hiding this comment.
I will add functionality to go from protojs to text proto without TP, but I don't get the strong reaction. So far, this is what we have been always doing. To get trace config, in recording page, in Data explorer. The idea of continuing with it was not so random.
There was a problem hiding this comment.
No the reaction here is because you are basically just dumping a shortcut to do proto to prototext of any proto trace processor understands. That's not the job of trace processor and I think that should be reasonably clear
2 participants
TP: Adds ProtoToText experimental function that alows us to show textoprotos to users on export
DE: Adds metrics v2 node, with support for one metric column