Skip to content

Add Proto for ProcState events#4770

Open
parthsane wants to merge 1 commit intomainfrom
dev/parthsane/add_proto_for_proc_state
Open

Add Proto for ProcState events#4770
parthsane wants to merge 1 commit intomainfrom
dev/parthsane/add_proto_for_proc_state

Conversation

@parthsane
Copy link

This change introduces a new proto message, AndroidProcState, for perfetto tracing of process state.

This will help understand memory usage.

This change introduces a new proto message, AndroidProcState, for
perfetto tracing of process state.

This will help understand memory usage.
@github-actions
Copy link

github-actions bot commented Feb 11, 2026

@parthsane parthsane marked this pull request as ready for review February 13, 2026 16:59
@parthsane parthsane requested a review from a team as a code owner February 13, 2026 16:59
}

// Information about ProcState of process in the system
message ProcState {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an ultra generic name. Please make this more specific. At the very least adding an android prefix but I would consider making this even more specific (because it's some sort of aggregate counter not actually an event on every proc state).

Also why are we even having this proto at all? IMO this should be a set of CounterTrack track events which is going to be both far more efficient and will remove the need to do de-interning in the trace processor.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if this was the correct way to do this, or if this was necessary to do.

I have implemented this as a counter track in the code. If this is a counter track, then does it not need this proto change? I can close the PR then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can do it with Counter tracks, you should. @zezeozue had exactly this convo in #4795 but the opposite was reached because it wasn't possible to emit in one shot.

@parthsane parthsane force-pushed the dev/parthsane/add_proto_for_proc_state branch from 89adb88 to da375d1 Compare February 13, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants