Conversation
This change introduces a new proto message, AndroidProcState, for perfetto tracing of process state. This will help understand memory usage.
🎨 Perfetto UI Builds |
| } | ||
|
|
||
| // Information about ProcState of process in the system | ||
| message ProcState { |
There was a problem hiding this comment.
This is an ultra generic name. Please make this more specific. At the very least adding an android prefix but I would consider making this even more specific (because it's some sort of aggregate counter not actually an event on every proc state).
Also why are we even having this proto at all? IMO this should be a set of CounterTrack track events which is going to be both far more efficient and will remove the need to do de-interning in the trace processor.
There was a problem hiding this comment.
I wasn't sure if this was the correct way to do this, or if this was necessary to do.
I have implemented this as a counter track in the code. If this is a counter track, then does it not need this proto change? I can close the PR then.
89adb88 to
da375d1
Compare
This change introduces a new proto message, AndroidProcState, for perfetto tracing of process state.
This will help understand memory usage.