ui: Datagrid disabled sorting and filtering unnecessarily#4793
Open
ui: Datagrid disabled sorting and filtering unnecessarily#4793
Conversation
stevegolton
approved these changes
Feb 13, 2026
aMayzner
force-pushed
the
dev/mayzner/sorting-from-datagrid
branch
from
ac2c59d to
ff3af6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix disabled filter and sort controls in the explore page datagrid.
The datagrid's filter menu items are gated by
filtersAreMutable, which onlychecked for
onFiltersChanged. The explore page usesonFilterAddinstead(to create filter nodes in the query graph), so the filter UI was hidden.
Sorting was unnecessarily gated by
columnsAreMutable, which is false whencolumns are provided in controlled mode without
onColumnsChanged. Sortingis a read-only view operation and shouldn't be tied to column mutability.
Changes
onFilterAddin thefiltersAreMutablecheckcolumnsAreMutable