tp: introduce ForgedTracePacketWriter for writing TracePackets efficiently#4799
Merged
LalitMaganti merged 3 commits intomainfrom Feb 13, 2026
Merged
tp: introduce ForgedTracePacketWriter for writing TracePackets efficiently#4799LalitMaganti merged 3 commits intomainfrom
LalitMaganti merged 3 commits intomainfrom
Conversation
LalitMaganti
force-pushed
the
dev/lalitm/forged-trace-packet
branch
2 times, most recently
from
3ec9301 to
e614b62
Compare
…ently This CL introduces a new class to write TracePacket protos efficiently and get out TraceBlobViews without creating tons of copies. There were already N instances of this in the codebase and we're now introducing a new one in #4768. Instead now we have a single class which works with TraceBlob + TraceBlobView and is stored in TraceProcessorContext so everyone can use it. It works in 4MB chunks and reuses them across TracePacket calls which makes it really efficient now to create these packets with 99% of cases being totally zero-copy.
LalitMaganti
force-pushed
the
dev/lalitm/forged-trace-packet
branch
from
e614b62 to
c71656e
Compare
primiano
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL introduces a new class to write TracePacket protos efficiently
and get out TraceBlobViews without creating tons of copies. There were
already N instances of this in the codebase and we're now introducing a
new one in #4768.
Instead now we have a single class which works with TraceBlob +
TraceBlobView and is stored in TraceProcessorContext so everyone can use
it. It works in 4MB chunks and reuses them across TracePacket calls
which makes it really efficient now to create these packets with 99% of
cases being totally zero-copy.