ui: Input events overlaps visualization command #4820
Open
gignat-dev wants to merge 3 commits intomainfrom
Open
ui: Input events overlaps visualization command #4820gignat-dev wants to merge 3 commits intomainfrom
gignat-dev wants to merge 3 commits intomainfrom
Conversation
This change adds a new command "Input Events: Visualize event overlaps (over selection)" to the InputEvents plugin. This allows users to visualize concurrent input processing density over a selected time range. The input event intervals are measured from the moment of dispatch until the ACK is received (i.e. dispatch_ts, total_latency_dur). - Registers a new visualizeOverlaps command that calculates event concurrency using the intervals_overlap_count logic. - Adds a parent "Input Events" counter track showing total concurrency across all channels. - Creates sub-tracks for each individual input event channel. - Orders channel tracks by their peak value (descending) to highlight potential input congestion. - Clips intervals to the selected time window (selection or visible window).
🎨 Perfetto UI Builds |
zezeozue
approved these changes
Feb 17, 2026
gignat-dev
changed the title
stevegolton
reviewed
Feb 17, 2026
| async visualizeOverlaps(ctx: Trace): Promise<void> { | ||
| const window = await getTimeSpanOfSelectionOrVisibleWindow(ctx); | ||
| const rootNode = await this.createRootTrack(ctx, window); | ||
| ctx.defaultWorkspace.pinnedTracksNode.addChildLast(rootNode); |
Member
There was a problem hiding this comment.
Adding a track directly to the pinned track node is unusual. You usually want to put the track in the normal workspace and the pin it, which means that when the user unpins it then it is still available in the normal track tree. Having said that there's nothing technically wrong with this I don't think, it's just unexpected. What's your intent here?
Contributor
Author
There was a problem hiding this comment.
This is a command and I don't think creating the tracks in the workspace is a good thing to do, considering we can call this command multiple times (over different selections)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new command "Input Events: Visualize event overlaps (over selection)"
to the InputEvents plugin. This allows users to visualize concurrent input processing density over a selected time range.
The input event intervals are measured
from the moment of dispatch until the ACK is received (i.e. dispatch_ts, total_latency_dur).
Screenshots:
